Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

philadelphia-generate: Clean up code #540

Merged
merged 1 commit into from
Dec 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/generate/philadelphia/orchestra.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def _group_fields_by_type(fields: list[_Field]) -> dict[str, list[_Field]]:


def _has_values(code_set: _CodeSet) -> bool:
return not code_set.id_ in _NO_VALUES and not code_set.type_ == 'Boolean'
return code_set.id_ not in _NO_VALUES and not code_set.type_ == 'Boolean'


def _sorted_codes(codes: list[_Code]) -> list[_Code]:
Expand Down
Loading