Update release procedure #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiasojed
requested review from
cmichi,
athei,
ascjones and
SkymanOne
as code owners
cmichi
approved these changes
Mar 11, 2024
smiasojed
commented
Mar 11, 2024
|
|
||
| - [ ] Check Substrate's [`node-template`](https://github.com/paritytech/substrate/commits/master/bin/node-template) | ||
| - [ ] Check Substrate's [`node-template`](https://github.com/paritytech/polkadot-sdk/tree/master//substrate/bin/node-template/), | ||
| which was renamed after the Polkadot release `1.8.0` to [`solochain-template`](https://github.com/paritytech/polkadot-sdk/tree/master/templates/solochain), |
There was a problem hiding this comment.
@pgherveou should we also add https://github.com/paritytech/polkadot-sdk/tree/master/templates/parachain since we have support for parachain mode?
ascjones
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Perhaps we should clarify here that there are two types of release we can do here:
- "internal" release with git refs and a github release tag, which gets picked up by our CI image for use with
inkandcargo-contract. We need this for faster iteration in case we don't want to wait for thecrates.iorelease - the crates.io release, which is preferable, still has the tag on github.
|
|
||
| - [ ] Check Substrate's [`node-template`](https://github.com/paritytech/substrate/commits/master/bin/node-template) | ||
| - [ ] Check Substrate's [`node-template`](https://github.com/paritytech/polkadot-sdk/tree/master//substrate/bin/node-template/), | ||
| which was renamed after the Polkadot release `1.8.0` to [`solochain-template`](https://github.com/paritytech/polkadot-sdk/tree/master/templates/solochain), |
ascjones
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.