Fix clippy

paritytech · Aug 21, 2024 · 5e22d0f · 5e22d0f
1 parent 887b957
commit 5e22d0f
Show file tree

Hide file tree

Showing 3 changed files with 783 additions and 926 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -64,27 +64,27 @@ jobs:
  - if: failure()
  uses: andymckay/cancel-action@271cfbfa11ca9222f7be99a47e8f929574549e0a # v0.4
 
- # clippy:
- #  name: cargo clippy
- #  needs: [fmt, machete]
- #  runs-on: ubuntu-latest
- #  steps:
- #  - name: Checkout sources
- #  uses: actions/checkout@v4
- #  - name: Install Rust compilation prerequisites
- #  run: |
- #  sudo apt update
- #  sudo apt install -y protobuf-compiler
- #  rustup toolchain install stable --profile minimal --no-self-update
- #  rustup target add wasm32-unknown-unknown --toolchain stable
- #  rustup toolchain install nightly --profile minimal --no-self-update
- #  rustup component add rustfmt clippy --toolchain nightly
- #  - name: Rust Cache
- #  uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3
- #  - name: cargo clippy
- #  run: cargo clippy --all-targets --all-features -- -D warnings
- #  - if: failure()
- #  uses: andymckay/cancel-action@271cfbfa11ca9222f7be99a47e8f929574549e0a # v0.4
+ clippy:
+ name: cargo clippy
+ needs: [fmt, machete]
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout sources
+ uses: actions/checkout@v4
+ - name: Install Rust compilation prerequisites
+ run: |
+ sudo apt update
+ sudo apt install -y protobuf-compiler
+ rustup toolchain install stable --profile minimal --no-self-update
+ rustup target add wasm32-unknown-unknown --toolchain stable
+ rustup toolchain install nightly --profile minimal --no-self-update
+ rustup component add rustfmt clippy --toolchain nightly
+ - name: Rust Cache
+ uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3
+ - name: cargo clippy
+ run: cargo clippy --all-targets --all-features -- -D warnings
+ - if: failure()
+ uses: andymckay/cancel-action@271cfbfa11ca9222f7be99a47e8f929574549e0a # v0.4
 
  check:
  name: cargo check
@@ -127,6 +127,7 @@ jobs:
  uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3
  - name: cargo doc
  run: RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --workspace --no-deps --document-private-items
+ # disabled for now as it fails with a no space left error
  # - name: Clean up documentation artifacts
  # run: rm -rf target/doc
  # - name: cargo test --doc
@@ -136,8 +137,7 @@ jobs:
 
  tests:
  name: cargo test
- needs: [check, docs]
- # needs: [clippy, check, docs]
+ needs: [clippy, check, docs]
  runs-on: ubuntu-latest-16-cores
  timeout-minutes: 30
  steps: