Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed user OR teams to users AND teams #30

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Fixed user OR teams to users AND teams #30

merged 4 commits into from
Aug 1, 2023

Conversation

Bullrich
Copy link
Contributor

Fixed the XOR condition for a OR condition.

Updated tests.

Closes #28

@Bullrich Bullrich added this to the Project launch milestone Jul 25, 2023
@Bullrich Bullrich self-assigned this Jul 25, 2023
@Bullrich Bullrich requested a review from a team as a code owner July 25, 2023 15:10
mordamax
mordamax approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cool to add test with team (A,B,C) and users (C, D), where they've merged to list of distinct users (A,B,C,D)

@Bullrich Bullrich enabled auto-merge (squash) August 1, 2023 09:46
@Bullrich Bullrich merged commit 2fca6de into main Aug 1, 2023
4 checks passed
@Bullrich Bullrich deleted the users-and-team-fix branch August 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mordamax mordamax mordamax approved these changes

Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging this pull request may close these issues.

Support both users AND teams.
2 participants
@Bullrich @mordamax