This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
primitives: make async backing params accessible for parachains #7659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added asynchronous backing params
slumber
added
A0-please_review
tdimitrov
approved these changes
Aug 24, 2023
ordian
approved these changes
Aug 24, 2023
| @@ -1165,6 +1165,8 @@ pub struct AbridgedHostConfiguration { | |||
| pub validation_upgrade_cooldown: BlockNumber, | |||
| /// The delay, in blocks, before a validation upgrade is applied. | |||
| pub validation_upgrade_delay: BlockNumber, | |||
| /// Asynchronous backing parameters. | |||
| pub async_backing_params: super::vstaging::AsyncBackingParams, | |||
There was a problem hiding this comment.
It seems a bit weird that v5 types depend on vstaging types. Also by making this change, shouldn't we bump a version? And stabilize this vstaging type?
There was a problem hiding this comment.
I think we should bump it along with staging runtime API becoming available. The change from this PR is backwards-compatible -- old AbridgedHostConfig can be decoded from the storage value as well.
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
AbridgedHostConfigurationwith asynchronous backing parameters, which were added directly under the abridged part. The migration adding this field has been executed on all chains, thus it's safe to decode new type.Needed for paritytech/cumulus#2706
cumulus companion: paritytech/cumulus#3055