This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Revert "[Substrate companion] update libp2p to 0.52.0 (#7472)" #7583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01fd49a.
altonen
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
labels
Aug 7, 2023
dmitry-markin
approved these changes
Aug 7, 2023
alexggh
reviewed
Aug 8, 2023
vstakhov
approved these changes
Aug 10, 2023
sandreim
approved these changes
Aug 10, 2023
kpp
reviewed
Aug 16, 2023
node/core/approval-voting/Cargo.toml
Outdated
@@ -11,7 +11,7 @@ futures-timer = "3.0.2" | |||
parity-scale-codec = { version = "3.6.1", default-features = false, features = ["bit-vec", "derive"] } | |||
gum = { package = "tracing-gum", path = "../../gum" } | |||
bitvec = { version = "1.0.0", default-features = false, features = ["alloc"] } | |||
lru = "0.11" | |||
lru = "0.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t see any reason why we should downgrade libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean to keep all 20 Cargo.tomls.
The CI pipeline was cancelled due to failure one of the required jobs. |
kpp
approved these changes
Aug 16, 2023
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 0aa9d94 |
bot merge |
Waiting for commit status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 01fd49a.
Companion for paritytech/substrate#14722
cumulus companion: paritytech/cumulus#2975