This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Publish RC container images #7556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2bfa79f.
chevdor
force-pushed
the
wk-230726-rc-container-image
branch
from
28d68dc
to
6a546da
Compare
chevdor
added
B0-silent
coderobe
reviewed
Aug 7, 2023
alvicsam
approved these changes
Aug 10, 2023
EgorPopelyaev
approved these changes
Aug 10, 2023
coderobe
approved these changes
Aug 10, 2023
altaua
reviewed
Aug 10, 2023
altaua
suggested changes
Aug 10, 2023
Co-authored-by: Mira Ressel <[email protected]>
Co-authored-by: Mira Ressel <[email protected]>
|
@altaua thanks for the feedback, I pushed the related fixes. |
…ilar folder in the gitlab CI
This seems far cleaner than copying the entire scripts/ folder into our job artifacts.
This lets us avoid a dependency on git in our CI image.
altaua
approved these changes
Aug 10, 2023
s0me0ne-unkn0wn
pushed a commit
that referenced
this pull request
Aug 15, 2023
* WIP * Add missing checkout * Add debuggin * Fix VAR name * Bug fix * Rework jobs * Revert "Rework jobs" This reverts commit 2bfa79f. * Add cache * Add temp default for testing * Add missing checkout * Fix patch * Comment out the GPG check for now * Rename polkadot_injected_release into a more appropriate polkadot_injected_debian * Refactoring / renaming * Introduce a generic image for binary injection * Flag files to be deleted and changes to be done * WIP * Fix multi binaries images * Add test build scripts * Remove old file, add polkadot build-injected script * Fix doc * Fix tagging * Add build of the injected container * Fix for docker * Remove the need for TTY * Handling container publishing * Fix owner and registry * Fix vars * Fix repo * Fix var naming * Fix case when there is no tag * Fix case with no tag * Handle error * Fix spacings * Fix tags * Remove unnecessary grep that may fail * Add final check * Clean up and introduce GPG check * Add doc * Add doc * Update doc/docker.md Co-authored-by: Mira Ressel <[email protected]> * type Co-authored-by: Mira Ressel <[email protected]> * Fix used VAR * Improve doc * ci: Update .build-push-image jobs to use the new build-injected.sh * ci: fix path to build-injected.sh script * Rename the release artifacts folder to prevent confusion due to a similar folder in the gitlab CI * ci: check out polkadot repo in .build-push-image This seems far cleaner than copying the entire scripts/ folder into our job artifacts. * feat(build-injected.sh): make PROJECT_ROOT configurable This lets us avoid a dependency on git in our CI image. * ci: build injected images with buildah * ci: pass full image names to zombienet * Add missing ignore --------- Co-authored-by: Mira Ressel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
parity/base-binimageThis PR introduces a new workflows that unfortunately cannot be triggered by other worfklow. This is due to the fact that we create new RCs via GH workflows but at the time the RC and its draft are created, there is no binary available to be attached yet.
The binaries are built in our build server, this is where the workflows dispatch event can be triggered, after the artifacts+sha256+sigantures have been uploaded to the release.
The new workflow, checks the artifacts, injects them into an image and publish this image with appropriate tags.
The PR to trigger the workflows disptach can only be finalize once this PR is merged and the new workflow gets an ID.
Todo
polkadotandstaking-miner)[ ] have https://github.com/paritytech/cleanroom/pull/103 readyTests:
dockerfiles/polkadot/*.Dockerfilebuilds & rundockerfiles/staking-miner/*.Dockerfilebuilds & run with generic imagedockerfiles/adder-collator/*.Dockerfilebuilds & run with generic imagedockerfiles/malus*.Dockerfilebuilds & run with generic imageNotes
So far, we are using a broad range of base images where bash is sometimes
/usr/bin/bashand sometimes/bin/bash.Once all images are based of
parity/base-bin, everything will need to be updated to/bin/bash.cc @oleg-plakida