Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF worker: Prevent access to env vars #7330

Merged
merged 5 commits into from
Aug 21, 2023
Merged

PVF worker: Prevent access to env vars #7330

merged 5 commits into from
Aug 21, 2023
+17 −0

Commits on Jun 4, 2023

  1. PVF worker: Prevent access to env vars

    @mrcnski
    mrcnski committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    a041b0c View commit details
    Browse the repository at this point in the history

  2. Clear env vars at time of spawning process

    @mrcnski
    mrcnski committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    7d60c2e View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Move env var clearage back to child...! Exception for RUST_LOG 

    Clearing env vars with the `std::process::Command` API didn't get everything on
Mac, namely `__CF_USER_TEXT_ENCODING` was still present. While we don't support
Mac itself as a secure system, the same issue could exist on some Linux systems
either now or in the future. So it is better to just clear it on the child-side
and not worry about it. We may not use the `Command` API in the future, anyway:
https://github.com/paritytech/polkadot/issues/4721
    @mrcnski
    mrcnski committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e0cfab7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrcnski/pvf-worker-prevent-access-to-env-vars

    @mrcnski
    mrcnski committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    555bc81 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Update impl guide

    @mrcnski
    mrcnski committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    2df9755 View commit details
    Browse the repository at this point in the history