Add OpenGov to Rococo and Westend runtimes #7272
Conversation
al3mart
added
B0-silent
al3mart
changed the title
SpendOrigin in Rococo to EnsureRootSpendOrigin in Rococo to EnsureRoot
|
Seems that I went to fast with the changes, will convert to draft for the moment until all commits are in place. |
al3mart
changed the title
SpendOrigin in Rococo to EnsureRootRoot as SpendOrigin in Rococo
|
Might as well transform this MR into introducing OpenGov in Rococo as there as been some interest. |
al3mart
changed the title
Root as SpendOrigin in Rococo
|
I might do a few more commits removing Gov1 from Rococo, but opening for reviews to see if anything needs addressing with the inclusion of the pallets mentioned in the description. |
| // --execution=wasm | ||
| // --wasm-execution=compiled | ||
| // --header=./file_header.txt | ||
| // --output=./runtime/kusama/src/weights/ |
There was a problem hiding this comment.
was it just copied from kusama? is it ok or ideally it should be generated with command bot?
There was a problem hiding this comment.
👍 I'd say that generating its own weights would be the way to go. I'll address this
There was a problem hiding this comment.
its one way to do this. to copy from other network or even substrate, and after run the weights via PR bot
There was a problem hiding this comment.
did you rerun them? this file would be rewritten
| max_deciding: 10, | ||
| decision_deposit: 100 * QUID, | ||
| prepare_period: 30 * MINUTES, | ||
| decision_period: 7 * DAYS, |
There was a problem hiding this comment.
not sure if we want the exact same configs, or we want to relax all constraints, to have shorter periods, approve and support curves, etc
| // --execution=wasm | ||
| // --wasm-execution=compiled | ||
| // --header=./file_header.txt | ||
| // --output=./runtime/kusama/src/weights/ |
There was a problem hiding this comment.
its one way to do this. to copy from other network or even substrate, and after run the weights via PR bot
Co-authored-by: Muharem Ismailov <[email protected]>
|
@mordamax @muharem @joepetrowski I think we can follow up with the review now :) It might be interesting to get this merge before the migration to the monorepo :P |
| // --execution=wasm | ||
| // --wasm-execution=compiled | ||
| // --header=./file_header.txt | ||
| // --output=./runtime/kusama/src/weights/ |
There was a problem hiding this comment.
did you rerun them? this file would be rewritten
|
almost there (: |
|
bot bench $ runtime rococo pallet_whitelist |
|
bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist |
|
@al3mart https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547 was started for your command Comment |
|
@al3mart Command |
|
bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist |
|
@al3mart https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453 was started for your command Comment |
…e=rococo --target_dir=polkadot --pallet=pallet_whitelist
|
@al3mart Command |
|
Ready for another review round |
As per this comment, the changes in this MR include the following pallets into [x] Rococo and [x] Westend runtimes:
And only for
westend-runtime:Following Kusama runtime config as a baseline.
Benchmarking of the following pallets done for Rococo and Westend:
And only for Westend:
pallet_treasury
Remove Gov1 from Rococo as in Introduce OpenGov into Polkadot #6701