Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to declare multiple impl blocks #6795

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Merge branch 'master' into pkhry/multiple_impl_blocks

bdc8ac5
Select commit
Loading
Failed to load commit list.
Open

add the ability to declare multiple impl blocks #6795

Merge branch 'master' into pkhry/multiple_impl_blocks
bdc8ac5
Select commit
Loading
Failed to load commit list.
paritytech-review-bot / review-bot failed Jan 20, 2025 in 0s

Missing 4 reviews

The following rules have failed:

  • Core developers
  • FRAME coders substrate

Details

Details per rule:

Core developers

Missing 1 review

Rule explanationRule 'Basic' requires a given amount of reviews from users/teams

For more info found out how the rules work in Review-bot types.

Missing reviews from teams

  • core-devs

Users approvals that counted towards this rule

GitHub users whose approval countsThis is a list of all the GitHub users whose approval would count towards fulfilling this rule:

FRAME coders substrate

Missing 3 reviews

Rule explanationRule 'And' has many required reviewers/teams and requires all of them to be fulfilled.

For more info found out how the rules work in Review-bot types.

Missing reviews from teams

  • core-devs
  • frame-coders
GitHub users whose approval countsThis is a list of all the GitHub users whose approval would count towards fulfilling this rule: