Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating pallet-state-trie-migration to benchmarking V2 #6617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Krayt78
Copy link

@Krayt78 Krayt78 commented Nov 22, 2024

Description

Migrated pallet-state-trie-migration benchmarking to the new benchmarking syntax v2.
This is part of #6202

@Krayt78 Krayt78 requested review from cheme and a team as code owners November 22, 2024 20:30
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about all the added semicolons, but update looks good

@Krayt78
Copy link
Author

Krayt78 commented Nov 25, 2024

not sure about all the added semicolons, but update looks good

They have been added by rustfmt, i think i have the default config file for it, can change it if u want.
https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#trailing_semicolon

@shawntabrizi
Copy link
Member

if rustfmt added it, then all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants