Notify telemetry only every second about the tx pool status #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this was done for every imported transaction. When a lot of transactions got imported, the import notification channel was filled. The underlying problem was that the `status` call is read locking the `validated_pool` which will be write locked by the internal submitting logic. Thus, the submitting and status reading was interferring which each other.
|
for the record: #6600 (comment) |
michalkucharczyk
approved these changes
Nov 22, 2024
|
/cmd prdoc --audience node_operator --bump patch |
eskimor
approved these changes
Nov 22, 2024
| _ = timer => { | ||
| timer = futures_timer::Delay::new(TELEMETRY_INTERVAL).fuse(); | ||
|
|
||
| if !tx_imported { |
There was a problem hiding this comment.
I guess we could avoid needless wakeups, by only re-initializing the timer in case a new notification came in. E.g. replace above tx_imported = true; with:
if !tx_imported {
tx_imported = true;
timer = futures_timer::Delay::new(TELEMETRY_INTERVAL).fuse();
}
There was a problem hiding this comment.
Sorry for deleting my previous comments here - I will reformulate them into a question.
future is not notified into import_notification_stream, also ready can be decreased by putting txs into the blocks.
Not sure if there is other place in transaction pool that updates this metric?
AndreiEres
approved these changes
Nov 22, 2024
lexnv
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this was done for every imported transaction. When a lot of transactions got imported, the import notification channel was filled. The underlying problem was that the
statuscall is read locking thevalidated_poolwhich will be write locked by the internal submitting logic. Thus, the submitting and status reading was interferring which each other.