Removes constraint in BlockNumberProvider from treasury
#6522
Conversation
| @@ -106,7 +106,7 @@ use frame_support::{ | |||
| weights::Weight, | |||
| BoundedVec, PalletId, | |||
| }; | |||
| use frame_system::pallet_prelude::BlockNumberFor; | |||
| use frame_system::pallet_prelude::BlockNumberFor as SystemBlockNumberFor; | |||
There was a problem hiding this comment.
Related to #6245, someday this type alias can be removed to avoid confusion.
There was a problem hiding this comment.
May be local block number? What system really means here. Also BlockNumberFor reference to the block's header, not system pallet
There was a problem hiding this comment.
May be local block number? What system really means here. Also
BlockNumberForreference to the block's header, not system pallet
Since we are importing it from frame_system's prelude, I believe that SystemBlockNumberFor is reasonable.
| @@ -122,6 +122,8 @@ pub type NegativeImbalanceOf<T, I = ()> = <<T as Config<I>>::Currency as Currenc | |||
| >>::NegativeImbalance; | |||
| type AccountIdLookupOf<T> = <<T as frame_system::Config>::Lookup as StaticLookup>::Source; | |||
| type BeneficiaryLookupOf<T, I> = <<T as Config<I>>::BeneficiaryLookup as StaticLookup>::Source; | |||
| pub type BlockNumberFor<T, I = ()> = | |||
There was a problem hiding this comment.
I would rather come up with new name, and not reuse the one which is used for local block number type
There was a problem hiding this comment.
I would rather come up with new name, and not reuse the one which is used for local block number type
I am actually doing it the other way around calling the local one as SystemBlockNumberFor.
There was a problem hiding this comment.
yes but this forces you to not import use frame_system::pallet_prelude::*;
I think having a different name that doesn't conflict with frame_system::BlockNumberFor would be a bit cleaner.
maybe like ProvidedBlockNumberFor? I agree the name is not good either.
anyway everything is good to me.
There was a problem hiding this comment.
yes but this forces you to not import
use frame_system::pallet_prelude::*;
Yeah, my hope is to be able to provide a different type in the prelude once enough pallets have been migrated.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
#3970 updated the treasury pallet to support relay chain block number provider. However, it added a constraint to the BlockNumberProvider to have the same block number type as frame_system:
This PR removes that constraint as suggested by @gui1117