Pure state sync refactoring (part-2) #6521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Nov 18, 2024
Co-authored-by: Bastian Köcher <[email protected]>
lexnv
reviewed
Nov 19, 2024
lexnv
reviewed
Nov 19, 2024
| /// is ready to be imported. | ||
| pub struct StateSync<B: BlockT, Client> { | ||
| target_block: B::Hash, | ||
| struct StateSyncMetadata<B: BlockT> { |
There was a problem hiding this comment.
minor nit; Would be useful to have some documatation on this struct and exposed methods
There was a problem hiding this comment.
It's a private struct and not publicly exposed. Feel free to add some docs if you think that's necessary :(
lexnv
approved these changes
Nov 19, 2024
Co-authored-by: Alexandru Vasile <[email protected]>
Merged
via the queue into
paritytech:master
with commit Nov 20, 2024
07a5933
194 of 198 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second part of the pure state sync refactoring, encapsulating
StateSyncMetadataas a separate entity. Now it's pretty straightforward what changes are needed for the persistent state sync as observed in the structStateSync:state: redirect directly to the DB layer instead of being accumulated in the memory.metadata: handle the state sync metadata on disk whenever the state is forwarded to the DB, resume an ongoing state sync on a restart, etc.