Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-xcm benchmarks to benchmark v2 syntax #6501

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

clangenb
Copy link
Contributor

Migrates pallet-xcm benchmarks to benchmark v2 syntax

@clangenb clangenb requested a review from a team as a code owner November 15, 2024 15:38
@acatangiu acatangiu requested a review from a team November 20, 2024 12:40
@acatangiu acatangiu added the R0-silent Changes should not be mentioned in any release notes label Nov 20, 2024
@acatangiu
Copy link
Contributor

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-b4c01097-eec9-4756-834a-2e25c7f7e579 to cancel this command or bot cancel to cancel all commands in this pull request.

@acatangiu
Copy link
Contributor

Benchmarks are not compiling, please fix them, then run them for at least one runtime using command above for sanity checking results.

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277/artifacts/download.

@clangenb
Copy link
Contributor Author

clangenb commented Nov 20, 2024

Can you please elaborate? There was indeed a warning of unused variables because I forgot to push the last commit. This is fixed now.

However, the benchmarks did compile, and they did run successfully if I interpret the results correctly from: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277.

Were you hinting at the warnings, or is there a compile error I am not aware of?

Edit: Do I have the rights to run the bot command too as a rank I fellow?

@acatangiu
Copy link
Contributor

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-08cd743b-fb6d-4212-af4e-51126cdad75e to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751/artifacts/download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants