pallet-utility: if_else
#6321
pallet-utility: if_else
#6321
Conversation
|
User @rainbow-promise, please sign the CLA here. |
|
Need to take a closer look at the extrinsic executions, even with the revisions it Is not quit there yet. |
|
looks fine now. need proper weights |
|
I am guessing the weight signature below the pallet index will have some form of condition as well? |
|
use the worst case (i.e. main + fallback). extra weight will be refunded as the actual weight is returned in the call |
this also applies to dispatch class? |
I would say dispatch class is the lowest class of the 2. if both are operational then it is operational. if one is normal then it is normal. etc. |
how can one determine the class of a |
take a look at batch, they do similar operation. You can use |
|
Also the |
| let caller = whitelisted_caller(); | ||
|
|
||
| #[extrinsic_call] | ||
| _(RawOrigin::Signed(caller), main_call, fallback_call); |
There was a problem hiding this comment.
The err branch should be slightly more costly, but difference should be negligible so it is ok.
There was a problem hiding this comment.
Ok.
Thanks for the review
There was a problem hiding this comment.
You can use a root call, it will be failing, like set_heap_page.
This would benchmark for the failing case, which is more costly
There was a problem hiding this comment.
...
#[benchmark]
fn if_else() {
let main_call = Box::new(frame_system::Call::set_heap_pages { pages: 0u64 }.into());
let fallback_call = Box::new(frame_system::Call::remark { remark: vec![1] }.into());
let caller = whitelisted_caller();
#[extrinsic_call]
_(RawOrigin::Signed(caller), main_call, fallback_call);
assert_last_event::<T>(Event::IfElseFallbackCalled { main_error: sp_runtime::DispatchError::Module(sp_runtime::ModuleError { index: 0, error: [5, 0, 0, 0], message: None }) }.into());
}
|
Need the CI to run some checks @ggwpez 🙏 |
substrate/frame/utility/src/tests.rs
Outdated
| assert_eq!(Balances::free_balance(1), 10); | ||
| assert_eq!(Balances::free_balance(2), 10); | ||
|
|
||
| System::assert_last_event(utility::Event::IfElseBothFailure { main_error: TokenError::FundsUnavailable.into(), fallback_error: TokenError::FundsUnavailable.into()}.into()); |
There was a problem hiding this comment.
It seems this event is not firing as expected.
There was a problem hiding this comment.
It looks to me that Err is executed first in this block leaving out the Event completely?
There was a problem hiding this comment.
ah indeed, the error will revert the storage, so we can't deposit event.
|
Review required! Latest push from author must always be reviewed |
prdoc/pr_6321.prdoc
Outdated
| - name: westend-runtime | ||
| bump: major | ||
| - name: pallet-utility | ||
| bump: major |
There was a problem hiding this comment.
this is not a breaking change so should be a minor bump?
There was a problem hiding this comment.
but the change is not in a breaking way? i.e. existing enum encode/decode as it was
substrate/frame/utility/src/lib.rs
Outdated
| if let Err(_fallback_error) = fallback_result { | ||
| // Both calls have faild. | ||
| return Err(sp_runtime::DispatchErrorWithPostInfo { | ||
| error: Error::<T>::IfElseBothFailure.into(), |
There was a problem hiding this comment.
not 100% sure about this as it mask the underlying error and makes debugging harder
There was a problem hiding this comment.
We can alternatively return the fallback error here
return Err(sp_runtime::DispatchErrorWithPostInfo {
error: _fallback_error.error,
post_info: Some(weight).into(),
})There was a problem hiding this comment.
yeah that will be better than not having anything
Utility Call Fallback
This introduces a new extrinsic:
if_elseWhich first attempts to dispatch the
maincall(s). If themaincall(s) fail, thefallbackcall(s) is dispatched instead. Both calls are executed with the same origin.In the event of a fallback failure the whole call fails with the weights returned.
Use Case
Some use cases might involve submitting a
batchtype call in either main, fallback or both.Resolves #6000
Polkadot Address: 1HbdqutFR8M535LpbLFT41w3j7v9ptEYGEJKmc6PKpqthZ8