Relay chain client pallet for AH Staking #6259
Draft
+1,075
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Oct 28, 2024
|
|
||
| assert_eq!(Outbound::get(), vec![MockMessages::SetSessionKeys((1, keys, vec![0, 0, 0]))]); | ||
| }) | ||
| } |
There was a problem hiding this comment.
Looks overall good, but it is hard to measure how correct this is, before seeing an e2e usage. I think this pallet should have very few unit tests, and many RC + Para tests based on XCM emulator.
There was a problem hiding this comment.
Yes that's a good point. That's why I ended up adding the integration-tests crate before completing these pallet unit tests, as the integration tests will be more useful.
10 tasks
kianenigma
reviewed
Oct 28, 2024
| //! termination, performs pre-checks and propagates that information to another pallet or consensus | ||
| //! system through the [`crate::Config::SessionKeysHandler`]. | ||
| //! | ||
| //! Callers can request to 1) set validator keys and 2) purge validator keys. These actions *may |
There was a problem hiding this comment.
Is this any different from calling pallet_xcm::send_xcm(transact { relay_chain_call })? I suggest consulting with @franciscoaguirre in the high level of design of RC <> AH interaction.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new pallet (
pallet-staking-rc-client) which abstracts the interfaces that staking needs to interact with but, in the context of AHM, will be in a different consensus system (i.e. in the relay chain). This new pallet acts as a session and on-offence handler broker and sits in "between" the staking pallet in AH and the relay chain, while being part of the AH runtime.The main design goal of this pallet is twofold:
trait SessionManagerand other interfaces in Asset Hub in a way that is transparent to the pallet staking. The current staking logic should have no changes (minimal at most) and it doesn't really care whether the session manager implementors and others are part of the AH runtime or in an external consensus system.staking > relay chainand abstract it as much as possible, implementing caching and other strategies to mimmic as much as possible a sync flow between staking and the relay chain.This PR also adds an integration test module where the behaviour between staking and the relay-chain pallets, brokered by
pallet-staking-rc-client, can be tested as close as possible to the real case scenario of multi-chain communication.Closes #6166