Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-timestamp benchmark to v2 #6258

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Migrate pallet-timestamp benchmark to v2 #6258

merged 6 commits into from
Oct 29, 2024

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier requested a review from a team as a code owner October 28, 2024 09:54
@AurevoirXavier AurevoirXavier mentioned this pull request Oct 28, 2024
Open
44 tasks
seadanda
seadanda approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few subjective comments

substrate/frame/timestamp/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/timestamp/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/timestamp/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/timestamp/src/benchmarking.rs Outdated Show resolved Hide resolved
AurevoirXavier and others added 2 commits October 29, 2024 19:56
@AurevoirXavier @seadanda
Update benchmarking.rs
84a0b33 
Co-authored-by: Dónal Murray <[email protected]>
@AurevoirXavier @seadanda
Update benchmarking.rs
f057359 
Co-authored-by: Dónal Murray <[email protected]>
@seadanda seadanda added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Oct 29, 2024
@shawntabrizi shawntabrizi added this pull request to the merge queue Oct 29, 2024
Merged via the queue into paritytech:master with commit 80cd5fd Oct 29, 2024
195 of 198 checks passed
@AurevoirXavier AurevoirXavier deleted the x/benchmarkv2-timestamp branch October 29, 2024 14:23
AurevoirXavier added a commit to AurevoirXavier/polkadot-sdk that referenced this pull request Oct 29, 2024
@AurevoirXavier
Fix review in paritytech#6258
673c473
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 29, 2024
@AurevoirXavier @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
dee9777 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <[email protected]>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 29, 2024
@AurevoirXavier @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
b41419a 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <[email protected]>
@shawntabrizi
Copy link
Member

strange, i removed it from the queue, but must have been to late :/

github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
@AurevoirXavier @shawntabrizi
Fix review in #6258 (#6275)
5e8a96a 
Co-authored-by: Shawn Tabrizi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@seadanda seadanda seadanda approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurevoirXavier @shawntabrizi @seadanda