Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport v1.14: fix: Update libp2p-websocket to v0.42.2 to fix panics (#5040) #5072

Merged
merged 4 commits into from
Jul 22, 2024

Commits on Jul 19, 2024

  1. fix: Update libp2p-websocket to v0.42.2 to fix panics (#5040)

    This release includes: libp2p/rust-libp2p#5482
    
    Which fixes substrate node crashing with libp2p trace:
    
    ```
     0: sp_panic_handler::set::{{closure}}
       1: std::panicking::rust_panic_with_hook
       2: std::panicking::begin_panic::{{closure}}
       3: std::sys_common::backtrace::__rust_end_short_backtrace
       4: std::panicking::begin_panic
       5: <quicksink::SinkImpl<S,F,T,A,E> as futures_sink::Sink<A>>::poll_ready
       6: <rw_stream_sink::RwStreamSink<S> as futures_io::if_std::AsyncWrite>::poll_write
       7: <libp2p_noise::io::framed::NoiseFramed<T,S> as futures_sink::Sink<&alloc::vec::Vec<u8>>>::poll_ready
       8: <libp2p_noise::io::Output<T> as futures_io::if_std::AsyncWrite>::poll_write
       9: <yamux::frame::io::Io<T> as futures_sink::Sink<yamux::frame::Frame<()>>>::poll_ready
      10: yamux::connection::Connection<T>::poll_next_inbound
      11: <libp2p_yamux::Muxer<C> as libp2p_core::muxing::StreamMuxer>::poll
      12: <libp2p_core::muxing::boxed::Wrap<T> as libp2p_core::muxing::StreamMuxer>::poll
      13: <libp2p_core::muxing::boxed::Wrap<T> as libp2p_core::muxing::StreamMuxer>::poll
      14: libp2p_swarm::connection::pool::task::new_for_established_connection::{{closure}}
      15: <sc_service::task_manager::prometheus_future::PrometheusFuture<T> as core::future::future::Future>::poll
      16: <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll
      17: <tracing_futures::Instrumented<T> as core::future::future::Future>::poll
      18: std::panicking::try
      19: tokio::runtime::task::harness::Harness<T,S>::poll
      20: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
      21: tokio::runtime::scheduler::multi_thread::worker::Context::run
      22: tokio::runtime::context::set_scheduler
      23: tokio::runtime::context::runtime::enter_runtime
      24: tokio::runtime::scheduler::multi_thread::worker::run
      25: tokio::runtime::task::core::Core<T,S>::poll
      26: tokio::runtime::task::harness::Harness<T,S>::poll
      27: std::sys_common::backtrace::__rust_begin_short_backtrace
      28: core::ops::function::FnOnce::call_once{{vtable.shim}}
      29: std::sys::pal::unix::thread::Thread::new::thread_start
      30: <unknown>
      31: <unknown>
    
    Thread 'tokio-runtime-worker' panicked at 'SinkImpl::poll_ready called after error.', /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quicksink-0.1.2/src/lib.rs:158
    ```
    
    Closes: #4934
    
    ---------
    
    Signed-off-by: Alexandru Vasile <[email protected]>
    lexnv committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    dcd21ce View commit details
    Browse the repository at this point in the history
  2. Update prdoc/pr_5040.prdoc

    Co-authored-by: Adrian Catangiu <[email protected]>
    lexnv and acatangiu authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f1df415 View commit details
    Browse the repository at this point in the history
  3. Move prdoc to prdoc/1.14.0

    Signed-off-by: Alexandru Vasile <[email protected]>
    lexnv committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    873e1f8 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/lexnv/backport-libp2p-fix' into …

    …lexnv/backport-libp2p-fix
    lexnv committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ab740a7 View commit details
    Browse the repository at this point in the history