People Chain migration: filter FeePaid judgements
#4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
commented
Jun 28, 2024
Comment on lines
+62
to
+67
| let judgements = []; | ||
| decodedJson.judgements.forEach((judgement) => { | ||
| if (!('feePaid' in judgement[1])) { | ||
| judgements.push(judgement); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Suggested change
| let judgements = []; | |
| decodedJson.judgements.forEach((judgement) => { | |
| if (!('feePaid' in judgement[1])) { | |
| judgements.push(judgement); | |
| } | |
| }); | |
| let judgements = []; | |
| console.log("before: ", decodedJson.judgements); | |
| decodedJson.judgements.forEach((judgement) => { | |
| if (!('feePaid' in judgement[1])) { | |
| judgements.push(judgement); | |
| } | |
| }); | |
| console.log("after: ", judgements); |
if you log it like ^, you get https://gist.github.com/muharem/41748f9ffb7cc8c58162d7fc0eb9c992
There was a problem hiding this comment.
Looks good, both for accounts that only have FeePaid and those that have other judgements.
joepetrowski
approved these changes
Jun 28, 2024
joepetrowski
merged commit d9c8753
into
nacho/people-chain-spec-with-migation
131 of 142 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter
FeePaidjudgements from the Relay Chain, as their deposits will not be migrated to the People Chain.