Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pallet Name Customisation #4806

Merged
merged 12 commits into from
Jul 1, 2024
Merged

Pallet Name Customisation #4806

merged 12 commits into from
Jul 1, 2024

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Jun 17, 2024

Added Instructions for pallet name customisation in the ReadMe

ndkazu added 2 commits June 17, 2024 18:15
Add Instructions for pallet name customisation
templates/minimal/README.md Outdated Show resolved Hide resolved
templates/minimal/README.md Outdated Show resolved Hide resolved
templates/minimal/README.md Outdated Show resolved Hide resolved
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@github-actions github-actions bot requested a review from bkchr June 17, 2024 22:22
Copy link
Contributor

Review required! Latest push from author must always be reviewed

ndkazu and others added 2 commits June 18, 2024 07:23
I'm always struggling with this one: American VS British English....

Co-authored-by: Bastian Köcher <[email protected]>
@bkchr bkchr requested a review from ggwpez June 24, 2024 19:20
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jun 24, 2024
@ggwpez ggwpez enabled auto-merge June 24, 2024 22:18
@github-actions github-actions bot requested a review from ggwpez June 27, 2024 04:48
@ndkazu
Copy link
Contributor Author

ndkazu commented Jun 28, 2024

I don't understand why this is happening:
"active_lock_reason":null}::error::Project needs to be reviewed again

@github-actions github-actions bot requested a review from ggwpez June 28, 2024 08:28
@ggwpez
Copy link
Member

ggwpez commented Jun 28, 2024

Please dont click the update button, otherwise it counts as a new commit and requires another review.

@ndkazu
Copy link
Contributor Author

ndkazu commented Jun 28, 2024

Please dont click the update button, otherwise it counts as a new commit and requires another review.

Got it, Sorry.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
templates/minimal/README.md Outdated Show resolved Hide resolved
templates/minimal/README.md Outdated Show resolved Hide resolved
@ndkazu
Copy link
Contributor Author

ndkazu commented Jul 1, 2024

Is it correct to assume that at this point, the failing Checks are not related to the modified ReadMe?

@bkchr bkchr disabled auto-merge July 1, 2024 20:18
@bkchr bkchr merged commit 18ed309 into paritytech:master Jul 1, 2024
15 of 16 checks passed
@kianenigma
Copy link
Contributor

Sorry for the blunt comment, but not a fan of this at all. Almost everything added here is pure Rust knowledge, as basic as how to rename a crate, a folder, and a variable. Isn't that a bit too off-topic? We don't have to re-teach people these basics here.

What is more relevant in my opinion is the part that you have the freedom to name your pallet in construct_runtime. This should then be primarily documented within construct_runtime/frame::runtime macro doc, and perhaps just a comment can live in the template to tell you to read it if you want to rename a pallet's name in the macro.

@alexggh alexggh mentioned this pull request Jul 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2024
CI required markdown step seems to start failing after
#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
@ndkazu ndkazu deleted the ndkazu-patch-1 branch July 3, 2024 08:14
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 7, 2024
Added Instructions for pallet name customisation in the ReadMe

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 7, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 8, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 8, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Added Instructions for pallet name customisation in the ReadMe

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
CI required markdown step seems to start failing after
paritytech#4806

Signed-off-by: Alexandru Gheorghe <[email protected]>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
Added Instructions for pallet name customisation in the ReadMe

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants