Add semver CI check #4279
Add semver CI check #4279
Conversation
Morganamilo
force-pushed
the
morganamilo/validate
branch
8 times, most recently
from
61cdc32 to
06ad5dd
Compare
Morganamilo
added
the
A1-insubstantial
Morganamilo
requested review from
bkchr,
EgorPopelyaev,
ggwpez,
liamaharon and
a team
|
This is finally ready after a lot of headache. See here https://github.com/paritytech/polkadot-sdk/actions/runs/8835275152/job/24259014297?pr=4279 for the output of the action. b4c1a79 is just to get some errors to show off the output. It will be reverted before merge. |
|
This is just a day after the 1.11 branch off. So it should be feasible to check over the PRdocs that have gotten in before this merge and go with a prdoc based release on the next release. |
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/psa-polkadot-sdk-enabling-semver/7616/1 |
|
Can you suppress compiler warnings? I think that nightly may have more warnings than stable. If it not just warns, but fails to compile, then we have to fix it though. |
|
I only just turned them them all because the build was failing to figure out why it was failing after pulling from master. Right now it's all or nothing cause the library isn't very good about controlling it. I can probably redirect the output to a buffer then dump the buffer on error but focusing on the last curicial bits first. |
Morganamilo
force-pushed
the
morganamilo/validate
branch
from
d5f4353 to
8145769
Compare
Morganamilo
force-pushed
the
morganamilo/validate
branch
from
68fb2d8 to
8d22382
Compare
This checks changed files against API surface changes against what the prdoc says. It will error if the detected semver change is greater than the one listed in the prdoc. It will also error if any crates were touched but not mentioned in the prdoc.
Morganamilo
force-pushed
the
morganamilo/validate
branch
from
5a40572 to
9a57823
Compare
Fixed this by passing rustflags to silence warnings. |
Morganamilo
force-pushed
the
morganamilo/validate
branch
from
49d69d1 to
e4734e9
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
This checks changed files against API surface changes against what the prdoc says. It will error if the detected semver change is greater than the one listed in the prdoc. It will also error if any crates were touched but not mentioned in the prdoc. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
This checks changed files against API surface changes against what the prdoc says. It will error if the detected semver change is greater than the one listed in the prdoc. It will also error if any crates were touched but not mentioned in the prdoc. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
This checks changed files against API surface changes against what the prdoc says. It will error if the detected semver change is greater than the one listed in the prdoc. It will also error if any crates were touched but not mentioned in the prdoc. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
This checks changed files against API surface changes against what the
prdoc says.
It will error if the detected semver change is greater than the one
listed in the prdoc. It will also error if any crates were touched but
not mentioned in the prdoc.