Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot-SDK Umbrella Crate #3935

Merged
merged 44 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
386b07d
First umbrella
ggwpez May 13, 2024
c918fe9
Fix FRAME macro stuff
ggwpez May 14, 2024
d7cd7db
Add docs
ggwpez May 14, 2024
9d4b6df
fmt
ggwpez May 14, 2024
aac3211
fmt toml
ggwpez May 14, 2024
7321721
Fix compile
ggwpez May 14, 2024
93de212
Fix test
ggwpez May 14, 2024
cbd764a
Fix umbrella
ggwpez May 14, 2024
9b3c45e
Add python generation script
ggwpez May 14, 2024
505ad60
Comment slow check
ggwpez May 14, 2024
a9f2739
Update
ggwpez May 15, 2024
d595ed0
Update script
ggwpez May 15, 2024
4dd2182
Merge remote-tracking branch 'origin/master' into oty-test-umbrella
ggwpez May 15, 2024
e588f9b
Update lockfile
ggwpez May 15, 2024
2bded84
Fix formatting
ggwpez May 15, 2024
d6e93ba
Add CI
ggwpez May 15, 2024
b9feb44
Add CI
ggwpez May 15, 2024
ca5d323
Fix CI
ggwpez May 15, 2024
65665e1
Fix CI
ggwpez May 15, 2024
8c15f6d
Fix CI
ggwpez May 15, 2024
b6eb564
Fix CI
ggwpez May 15, 2024
a694824
Fix CI
ggwpez May 15, 2024
65af809
Fix generator
ggwpez May 15, 2024
88ab975
Fix CI
ggwpez May 15, 2024
cb46f78
Fix docs
ggwpez May 15, 2024
a01dfa6
Cleanup
ggwpez May 15, 2024
890473a
Cleanup macros
ggwpez May 15, 2024
5152471
Cleanup
ggwpez May 15, 2024
dbdeaf0
Revert tt macro change
ggwpez May 15, 2024
4357d9a
Fix CI
ggwpez May 15, 2024
3ffe52c
Add prdoc
ggwpez May 15, 2024
2ddb4fb
Fix prdoc
ggwpez May 15, 2024
0877939
Remove unneeded features
ggwpez May 15, 2024
ec5b065
Merge remote-tracking branch 'origin/master' into oty-test-umbrella
ggwpez May 15, 2024
a147bc3
Post merge
ggwpez May 15, 2024
80660fb
Merge branch 'master' into oty-test-umbrella
ggwpez May 21, 2024
2f8cb66
Merge remote-tracking branch 'origin/master' into oty-test-umbrella
ggwpez May 23, 2024
0c3ebca
Add frame-metadata-extension to the umbrella
ggwpez May 23, 2024
b50c977
Lockfile
ggwpez May 23, 2024
70a41f4
Fix prdoc
ggwpez May 23, 2024
53add30
Fix doctest
ggwpez May 24, 2024
02628e1
Merge remote-tracking branch 'origin/master' into oty-test-umbrella
ggwpez May 24, 2024
176181c
Fix link
ggwpez May 24, 2024
d064ced
Toml format
ggwpez May 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .config/zepter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,13 @@ workflows:
'--show-path',
'--quiet',
]
# Same as `check`, but with the `--fix` flag.
# The umbrella crate uses more features, so we to check those too:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny thing: I guess the word need or have is missing: so we need/have to check

check_umbrella:
- [ $check.0, '--features=serde,experimental,with-tracing,tuples-96,with-tracing', '-p=polkadot-sdk' ]
# Same as `check_*`, but with the `--fix` flag.
default:
- [ $check.0, '--fix' ]
- [ $check_umbrella.0, '--fix' ]

# Will be displayed when any workflow fails:
help:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Check
uses: hack-ink/cargo-featalign-action@bea88a864d6ca7d0c53c26f1391ce1d431dc7f34 # v0.1.1
with:
crate: substrate/bin/node/runtime
crate: templates/parachain/runtime/
features: std,runtime-benchmarks,try-runtime
ignore: sc-executor
default-std: true
30 changes: 30 additions & 0 deletions .github/workflows/checks-quick.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,33 @@ jobs:
run: |
echo "Checking markdown formatting. More info: docs/contributor/markdown_linting.md"
markdownlint --config "$CONFIG" --ignore target .
check-umbrella:
runs-on: arc-runners-polkadot-sdk
timeout-minutes: 10
needs: [set-image]
container:
image: ${{ needs.set-image.outputs.IMAGE }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.0 (22. Sep 2023)
- name: install python deps
run: |
sudo apt-get update && sudo apt-get install -y python3-pip python3
pip3 install "cargo-workspace>=1.2.4" toml
- name: check umbrella correctness
run: |
python3 scripts/generate-umbrella.py --sdk . --version 0.1.0
cargo +nightly fmt --all
if [ -n "$(git status --porcelain)" ]; then
cat <<EOF
👋 Hello developer! The SemVer information that you declared in the prdoc file did not match what the CI detected.

Please check the output above and see the following links for more help:
- https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/prdoc.md#record-semver-changes
- https://forum.polkadot.network/t/psa-polkadot-sdk-to-use-semver

Otherwise feel free to ask in the Merge Request or in Matrix chat.
EOF

git diff
exit 1
fi
Loading
Loading