Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map "error" and "out of range" values to None #41

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

vesuvisian
Copy link

@vesuvisian vesuvisian commented Apr 24, 2021

The ST0601.11 standard provides for certain "error" and "out of range" values (see for example Sensor Latitude in the table on page 17). These values currently trigger ValueErrors when the library attempts to parse them. This PR proposes instead to map them to a value of None.

*This is my first time attempting to contribute to anything public, so apologies if I'm doing it wrong or stepping on toes.

Fix issue #40

@All4Gis
Copy link
Collaborator

All4Gis commented Apr 25, 2021

Thanks, Can you fix the pipeline?Only add default value in this line:

def float_to_bytes(value, _domain, _range, _error):
to :

def float_to_bytes(value, _domain, _range, _error=None):

@vesuvisian
Copy link
Author

Okay, I've now updated float_to_bytes as you requested.

@All4Gis All4Gis merged commit cfd1682 into paretech:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants