-
Notifications
You must be signed in to change notification settings - Fork 20
Add Product Model and Family Variant for Akeneo's latest version 2.3 #23
base: master
Are you sure you want to change the base?
Conversation
… the actual response order
@progunnerr I tried your fork, I didn't have time to investigate, but a simple Task getStringTask = Client.CreateAsync(product); that is working with the nuget repository version seems to fail with your version |
@dsonnet Hi, thanks for the check. That is strange. But I didn't made any changes to CreateAsync method. Only changes pertain to Product model itself. Also, the tests shows that CreateAsync method passed tests(PFA screenshots). One potential cause could be that in the Product model you are using VariantGroup field which I guess is no longer an attribute in Akeneo. See Akeneo API referenc here At this point, it is best if you can dig further and provide more info about the failure? ---- CreateAsync Method --------- Passed Tests ------ |
@pardahlman Hi, I am wondering if you got a chance to review the pull request. I think this would really help the community. Please let me know your thoughts? |
@progunnerr I found the issue with your code. In the product model you are using properties that are Enterprise Edition specific, this fails on the community edition. |
@dsonnet Thanks. Can you please try now? I removed the attribute that I think was the problem. |
Yes I already patched your code on my local machine and without this attribute it is working |
@dsonnet Great! |
@pardahlman It would be great to have this merged |
@progunnerr in your new implementation of GetAllAsync you dropped support for parentcode, this is not optimal if you try to fetch the attributeoptions where you need some kind of server filtering to get only the attributes options of a specific attribute. |
@progunnerr , @dsonnet is the method GetAllAsync working? I'm trying to get all "products" per 100 items, but the method doesn't respond the second time it tries to get items. I also tried lowering the items per call but without success. |
@progunnerr: if you look at the function itself, it contains a do while and inside the do while it calls the function GetManyAsync with a limit (max 100 results per call). |
Hello,
Thank you for the project. I made a quite a bit of improvements. It was too late before I realized that I should have created multiple pull requests instead. Sorry about that.
https://api.akeneo.com/documentation/pagination.html
From Akeneo: