replace serve-handler with serve-static #9594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iacore
force-pushed
the
patch-serve-static
branch
from
4d60673
to
696b849
Compare
mischnic
reviewed
Mar 22, 2024
Comment on lines
-373
to
-376
| lstat: path => fs.stat(path), | ||
| realpath: path => fs.realpath(path), | ||
| createReadStream: (path, options) => fs.createReadStream(path, options), | ||
| readdir: path => fs.readdir(path), |
There was a problem hiding this comment.
Is it possible to override the FS of server-static? You could use an in-memory FS with Parcel, then it would not work without this
There was a problem hiding this comment.
No. Not that I know of.
I thought the fs.* refer to real files.
In-memory FS: /dev/shm/xxxx
There was a problem hiding this comment.
Parcel has other implementations of the fs interface, such as https://github.com/parcel-bundler/parcel/blob/v2/packages/core/fs/src/MemoryFS.js
That's why the fs parameter exist in that function
There was a problem hiding this comment.
In that case, Parcel can fork serve-static (it's small).
https://github.com/expressjs/serve-static/blob/master/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
serve-handlerwithserve-staticHopefully this PR fixes #9390. I can't test this out myself since
yarn installfails on my machine.Can someone
test this for mefix this?✔️ PR Todo