Added start of rpc implemention for Rust <-> JS plugins (#9777)

* Added start of rpc implemention to talk to JS plugins * Removing [lib] * Changed naming order * unit tests * warnings and tests
parcel-bundler · Jun 7, 2024 · 466c61e · 466c61e
1 parent a323b03
commit 466c61e
Show file tree

Hide file tree

Showing 34 changed files with 489 additions and 325 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/node-bindings/Cargo.toml b/crates/node-bindings/Cargo.toml
@@ -17,6 +17,7 @@ openssl = ["sentry/native-tls"]
 napi-derive = "2.16.3"
 parcel-js-swc-core = { path = "../../packages/transformers/js/core" }
 parcel-resolver = { path = "../../packages/utils/node-resolver-rs" }
+parcel_plugin_rpc = { path = "../parcel_plugin_rpc", features = ["nodejs"] }
 parcel = { path = "../parcel" }
 dashmap = "5.4.0"
 xxhash-rust = { version = "0.8.2", features = ["xxh3"] }

diff --git a/crates/node-bindings/src/parcel/parcel.rs b/crates/node-bindings/src/parcel/parcel.rs
@@ -7,6 +7,7 @@ use napi_derive::napi;
 use parcel::file_system::FileSystemRef;
 use parcel::Parcel;
 use parcel::ParcelOptions;
+use parcel_plugin_rpc::nodejs::RpcHostNodejs;
 
 use crate::file_system::FileSystemNapi;
 
@@ -24,14 +25,19 @@ impl ParcelNapi {
  let thread_id = std::thread::current().id();
  tracing::trace!(?thread_id, "parcel-napi initialize");
 
+ let rpc_host_nodejs = RpcHostNodejs::new();
+
  let mut fs = None::<FileSystemRef>;
 
  if options.has_named_property("fs")? {
  let fs_raw: JsObject = options.get_named_property("fs")?;
  fs.replace(Arc::new(FileSystemNapi::new(&env, fs_raw)?));
  }
 
- let parcel = Parcel::new(ParcelOptions { fs });
+ let parcel = Parcel::new(ParcelOptions {
+ fs,
+ rpc: Some(Arc::new(rpc_host_nodejs)),
+ });
 
  Ok(Self {
  internal: Arc::new(parcel),

diff --git a/crates/parcel/Cargo.toml b/crates/parcel/Cargo.toml
@@ -14,5 +14,6 @@ parcel_filesystem = { path = "../parcel_filesystem" }
 parcel_package_manager = { path = "../parcel_package_manager" }
 parcel_plugin_resolver = { path = "../parcel_plugin_resolver" }
 parcel_plugin_transformer_js = { path = "../parcel_plugin_transformer_js" }
+parcel_plugin_rpc = { path = "../parcel_plugin_rpc" }
 
 anyhow = "1.0.82"
diff --git a/crates/parcel/src/lib.rs b/crates/parcel/src/lib.rs
@@ -2,8 +2,6 @@
 
 #[allow(dead_code)]
 #[allow(unused_variables)]
-mod napi;
-
 pub mod parcel;
 pub use parcel::*;
 pub use parcel_filesystem as file_system;

diff --git a/crates/parcel/src/napi/napi_bundler_plugin.rs b/crates/parcel/src/napi/napi_bundler_plugin.rs
diff --git a/crates/parcel/src/napi/napi_compressor_plugin.rs b/crates/parcel/src/napi/napi_compressor_plugin.rs
diff --git a/crates/parcel/src/napi/napi_namer_plugin.rs b/crates/parcel/src/napi/napi_namer_plugin.rs
diff --git a/crates/parcel/src/napi/napi_optimizer_plugin.rs b/crates/parcel/src/napi/napi_optimizer_plugin.rs
diff --git a/crates/parcel/src/napi/napi_packager_plugin.rs b/crates/parcel/src/napi/napi_packager_plugin.rs
diff --git a/crates/parcel/src/napi/napi_reporter_plugin.rs b/crates/parcel/src/napi/napi_reporter_plugin.rs
diff --git a/crates/parcel/src/napi/napi_resolver_plugin.rs b/crates/parcel/src/napi/napi_resolver_plugin.rs
diff --git a/crates/parcel/src/napi/napi_runtime_plugin.rs b/crates/parcel/src/napi/napi_runtime_plugin.rs
diff --git a/crates/parcel/src/napi/napi_transformer_plugin.rs b/crates/parcel/src/napi/napi_transformer_plugin.rs
diff --git a/crates/parcel/src/parcel.rs b/crates/parcel/src/parcel.rs
@@ -3,22 +3,29 @@ use std::sync::Arc;
 use parcel_filesystem::os_file_system::OsFileSystem;
 use parcel_filesystem::FileSystemRef;
 use parcel_package_manager::NodePackageManager;
+use parcel_plugin_rpc::RpcHostRef;
 
 pub struct Parcel {
  pub fs: FileSystemRef,
+ pub rpc: Option<RpcHostRef>,
 }
 
 pub struct ParcelOptions {
  pub fs: Option<FileSystemRef>,
+ pub rpc: Option<RpcHostRef>,
 }
 
 impl Parcel {
  pub fn new(options: ParcelOptions) -> Self {
  let fs = options
  .fs
  .unwrap_or_else(|| Arc::new(OsFileSystem::default()));
+
  let _node_package_manager = NodePackageManager::new("project_root", fs.clone());
 
- Self { fs }
+ Self {
+ fs,
+ rpc: options.rpc,
+ }
  }
 }