Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to compile pony runtime with gcc 7.x #865

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Thizizmyname
Copy link

Make sure these boxes are checked before submitting your pull request:

  • [✓] Description of the pull request stating the problem and the solution
  • [ x ] Tests (if applicable)
  • [ x ] Documentation (if applicable)

This is a solution to #863
The ponyrt needs to be compiled with the flag -latomic as well as every encore project needs to be linked with said flag.

NOTE: This should be tested on multiple devices before acceptance

@Thizizmyname
Copy link
Author

tests compile and pass on:
Ubuntu 17.10
gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
clang version 4.0.1-6 (tags/RELEASE_401/final)

@TobiasWrigstad
Copy link
Contributor

I can confirm that this works. Can someone check backwards compatibility on a old GCC?

Alternative option: only support clang. Thoughts?

@EliasC
Copy link
Contributor

EliasC commented Jul 10, 2018

Can confirm that this compiles on my machine (running clang 700.1.81 on MacOSX 10.10.5). I don't have GCC installed.

EDIT: I cannot actually compile Encore programs in this build:

ld: library not found for -latomic

Alternative option: only support clang. Thoughts?

I'm fine with only supporting clang. Would we be excluding any platforms doing that?

@albertnetymk
Copy link
Contributor

only support clang. Thoughts?

#864

Would we be excluding any platforms doing that?

It's OK to assume none until the real need appears.

@TobiasWrigstad
Copy link
Contributor

TobiasWrigstad commented Jul 16, 2018 via email

@albertnetymk
Copy link
Contributor

Given the merge of #864, clean clone should work on linux with clang installed. Could someone else with a linux box confirm it?

@ElieOaks ElieOaks mentioned this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants