-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up stress tests. #829
base: development
Are you sure you want to change the base?
Cleaned up stress tests. #829
Conversation
Listing each directory explicitly under Using explicit relative path while invoking the compiler seems a bit odd as well. |
If you don't mention the directories, then the screen is filled with warnings, though the tests will still pass. I added the explicit path to the encore compiler to make sure that it was running the right one — perhaps this is redundant and handled already by the testing script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I won't merge until the author confirms if a Makefile
is needed to do the stress testing. If the author fixes this issue before 15.00, I'll merge today
|
||
all: main | ||
|
||
run: main | ||
/usr/bin/time ./main | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Makefile
needed by the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because there is no other way to pass the -O3 flag to the compiler.
(Whether the -O3 flag is really required is a question for the BoundedBuffer implementor.)
The reason for tidying up the Makefile was to reduce errors in the output, and increase faith in make stress
.
77ca53d
to
c7e22e3
Compare
@kikofernandez Ping! |
@kikofernandez Are you fishing for more cake? |
CI fails Sent from my Samsung GT-I9506 using FastHub |
CI fails because I keep updating src/tests/IGNORED_FILES.grep whenever I add new (stress) tests. |
f108e11
to
2d4449b
Compare
Added entries into IGNORED_FILES.grep to reduce number of warning produced when running stress tests.
Made one Makefile a little more robust.