Merge pull request #960 from Shinsina/get-as-object-usage

Use getAsObject for incoming attributes from input
parameter1 · Sep 13, 2024 · ee8cb4f · ee8cb4f
2 parents 6d5b83f + 35c359e
commit ee8cb4f
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/services/graphql-server/src/graphql/resolvers/email/newsletter.js b/services/graphql-server/src/graphql/resolvers/email/newsletter.js
@@ -16,17 +16,13 @@ module.exports = {
     updateEmailNewsletterProvider: async (_, { input }, { base4rest, basedb }) => {
       validateRest(base4rest);
       const type = 'email/product/newsletter';
-      const {
-        id,
-        type: providerType,
-        providerId,
-        attributes,
-      } = input;
+      const { id, type: providerType, providerId } = input;
 
       const product = await basedb.strictFindById('platform.Product', id, { projection: { provider: 1 } });
+      const attributesFromInput = getAsObject(input, 'attributes');
       const existingAttributes = getAsObject(product, 'provider.attributes');
-      const mergedAttributes = { ...existingAttributes, ...attributes };
-      Object.entries(attributes).forEach(([key, value]) => {
+      const mergedAttributes = { ...existingAttributes, ...attributesFromInput };
+      Object.entries(attributesFromInput).forEach(([key, value]) => {
         if (value === null) delete mergedAttributes[key];
       });