Merge pull request #59 from zarathustra323/pass-dsl-params

Pass `targetTag` and `requestFrame` to init components
parameter1 · Mar 24, 2021 · 25846c2 · 25846c2
2 parents ba66159 + 031485f
commit 25846c2
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 4 deletions.
diff --git a/packages/marko-web-gam/components/init.marko b/packages/marko-web-gam/components/init.marko
@@ -6,6 +6,8 @@ $ const { on } = input;
     name="googletag"
     src=src
     on=on
+    request-frame=input.requestFrame
+    target-tag=input.targetTag
     init="window.googletag = window.googletag || {}; window.googletag.cmd = window.googletag.cmd || [];"
   />
 </if>

diff --git a/packages/marko-web-gam/components/marko.json b/packages/marko-web-gam/components/marko.json
@@ -2,7 +2,9 @@
   "<marko-web-gam-init>": {
     "template": "./init.marko",
     "@src": "string",
-    "@on": "string"
+    "@on": "string",
+    "@target-tag": "string",
+    "@request-frame": "boolean"
   },
   "<marko-web-gam-head>": {
     "template": "./head.marko",

diff --git a/packages/marko-web-gtm/components/init.marko b/packages/marko-web-gtm/components/init.marko
@@ -23,6 +23,8 @@ $ const start = input.start == null ? false : input.start;
       name=`${name}_${containerId}`
       src=src
       on=on
+      request-frame=input.requestFrame
+      target-tag=input.targetTag
       init=`var w = window, l = '${name}'; w[l] = w[l] || [];`
     />
   </for>

diff --git a/packages/marko-web-gtm/components/marko.json b/packages/marko-web-gtm/components/marko.json
@@ -14,7 +14,9 @@
       "type": "boolean",
       "default-value": false
     },
-    "@on": "string"
+    "@on": "string",
+    "@target-tag": "string",
+    "@request-frame": "boolean"
   },
   "<marko-web-gtm-start>": {
     "template": "./start.marko",

diff --git a/packages/marko-web-native-x/components/init.marko b/packages/marko-web-native-x/components/init.marko
@@ -10,6 +10,8 @@ $ const src = "https://cdn.parameter1.com/native-x/1.0.0-rc.4.3.js";
         name="fortnight"
         src=src
         on=on
+        request-frame=input.requestFrame
+        target-tag=input.targetTag
         init="var i = window, r = 'fortnight'; i['FortnightObject'] = r; i[r] = i[r] || function() { (i[r].q = i[r].q || []).push(arguments); };"
       />
     </if>

diff --git a/packages/marko-web-native-x/components/marko.json b/packages/marko-web-native-x/components/marko.json
@@ -3,7 +3,9 @@
     "template": "./init.marko",
     "@uri": "string",
     "@enabled": "boolean",
-    "@on": "string"
+    "@on": "string",
+    "@target-tag": "string",
+    "@request-frame": "boolean"
   },
   "<marko-web-native-x-retrieve>": {
     "template": "./retrieve.marko",

diff --git a/packages/marko-web-p1-events/components/init.marko b/packages/marko-web-p1-events/components/init.marko
@@ -16,6 +16,8 @@ $ const identityQueryBuilder = `identityQueryBuilder: function(query) { ${input.
       name="p1events"
       src=scriptSrc
       on=on
+      request-frame=input.requestFrame
+      target-tag=input.targetTag
       init="var i = window, r = 'p1events'; i['__p1e'] = r; i[r] = i[r] || function() { (i[r].q = i[r].q || []).push(arguments); };"
     />
   </if>

diff --git a/packages/marko-web-p1-events/components/marko.json b/packages/marko-web-p1-events/components/marko.json
@@ -4,7 +4,9 @@
     "@script-src": "string",
     "@uri": "string",
     "@identity-query-builder": "string",
-    "@on": "string"
+    "@on": "string",
+    "@target-tag": "string",
+    "@request-frame": "boolean"
   },
   "<marko-web-p1-events-track-content>": {
     "template": "./track-content.marko",