Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project cleanup 01 #645

Merged
merged 27 commits into from
Jul 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
4fa2e03
Refactor hide compiler status window from jQuery to DOM model.
pjewald Jul 14, 2021
53d29f0
Remove deprecated nudge timer code.
pjewald Jul 14, 2021
6b403cc
Move workspace setup code.
pjewald Jul 14, 2021
8d755d5
Refactor hide compiler status window code from jQuery to DOM model.
pjewald Jul 14, 2021
0dda656
Add getter and setter for project created date field.
pjewald Jul 14, 2021
e87fa01
Update to verify that json is valid before parsing the data.
pjewald Jul 14, 2021
195a89b
Add code to default project created on date is one is not provided in…
pjewald Jul 14, 2021
cdb00b7
Move file to Project folder.
pjewald Jul 14, 2021
27916df
Improve function description.
pjewald Jul 14, 2021
5980472
Refactor module local function names. Improve function description.
pjewald Jul 14, 2021
164f22e
Remove todo for issue solo#261.
pjewald Jul 14, 2021
09685f5
Remove debug logging.
pjewald Jul 14, 2021
ec07ad0
Continuing work on project time-stamps.
pjewald Jul 15, 2021
3ea013f
Invert logic to remove code.
zfi Jul 15, 2021
cd203f2
Rework logic to ensure that the constructor receives a Date object.
zfi Jul 15, 2021
736b721
Remove build file that is no longer used.
zfi Jul 15, 2021
cdc1101
Refactor the contents of modals.js to edit_project.js.
zfi Jul 16, 2021
d3dfe7b
Move compiler dialog functions from edit_project module.
zfi Jul 16, 2021
f2602b8
Move the hide compiler window function to the module that uses it.
zfi Jul 16, 2021
6dfc8bd
Remove the modules.js after migrating contents to more appropriate mo…
zfi Jul 16, 2021
ec7a05d
Refactor event handler names.
zfi Jul 16, 2021
7025dee
More updates to corral the project created on datestamp.
pjewald Jul 16, 2021
e9f24a6
Remove debugging message and unused HTML code.
pjewald Jul 16, 2021
ebee88a
Refactor out jQuery references. Ensure that project details are not h…
pjewald Jul 16, 2021
287eb71
Manage project load failure in try/catch block.
pjewald Jul 16, 2021
301ba3d
Group project date code and add more comments.
pjewald Jul 16, 2021
7031df1
Preparing for release 1.6.0
pjewald Jul 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 0 additions & 206 deletions build_propc.py

This file was deleted.

24 changes: 23 additions & 1 deletion src/modules/blocklyc.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import {loadToolbox} from './editor';
import {CodeEditor, getSourceEditor} from './code_editor';
import {getProjectInitialState, Project} from './project';
import {cloudCompile} from './compiler';
import {showCannotCompileEmptyProject, showCompilerStatusWindow} from './modals';
import {
delay, logConsoleMessage, getURLParameter, sanitizeFilename, utils, prettyCode} from './utility';

Expand Down Expand Up @@ -174,6 +173,29 @@ const graph_data = {
],
};


/**
* Display a dialog window that warns of an attempt to compile
* an empty project.
*
* @param {string} title is the text to include in the dialog title bar
* @param {string} body is the text that is displayed in the body of the dialog
*/
const showCannotCompileEmptyProject = (title, body) => {
utils.showMessage(title, body);
};


/**
* Display the compiler status modal window
* @param {string} titleBar is the text that will appear in the modal title bar
*/
const showCompilerStatusWindow = (titleBar) => {
$('#compile-dialog-title').text(titleBar);
$('#compile-console').val('Compile... ');
$('#compile-dialog').modal('show');
};

/**
* This is the onClick event handler for the compile toolbar button
*/
Expand Down
12 changes: 11 additions & 1 deletion src/modules/client_connection.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ function wsProcessUiCommand(message) {
break;

case WS_ACTION_CLOSE_COMPILE:
$('#compile-dialog').modal('hide');
hideCompilerStatusWindow();
$('#compile-console').val('');
break;

Expand Down Expand Up @@ -560,3 +560,13 @@ export const getComPort = function() {
return commPortSelection;
}
};

/**
* Close the compile progress window
*/
const hideCompilerStatusWindow = () => {
console.log('Hide Compiler dialog window.');
const dialog = document.getElementById('compile-dialog');
dialog.modal('hide');
};

7 changes: 1 addition & 6 deletions src/modules/client_service.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,7 @@ export const clientService = {
*/
setSelectedPort: function(portName) {
// Do not select the 'Searching...' as a port
if (portName.startsWith('Search')) {
console.log(`Selecting a port while searching.`);
return;
}

if (this.activeConnection) {
if (!portName.startsWith('Search') && this.activeConnection) {
if (portName !== this.getSelectedPort()) {
this.selectedPort_ = portName;
// Notify Launcher of the selected port
Expand Down
4 changes: 2 additions & 2 deletions src/modules/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ export const EnableSentry = true;
* {b#} is the beta release number.
* {rc#} is the release candidate number.
*/
export const APP_VERSION = '1.5.13';
export const APP_VERSION = '1.6.0';

/**
* Incremental build number. This gets updated before any release
* to QA or production.
* @type {string}
*/
export const APP_BUILD = '220';
export const APP_BUILD = '221';

/**
* Development build stage designator
Expand Down
Loading