Skip to content

Commit

Permalink
Fix intermittent download failures (PROPMAN-38)
Browse files Browse the repository at this point in the history
- Changed reset delay from 80ms to recommended 95ms
- Start timeout counters after executing initial reset
- Fix infamous "UnknownError" bug that aborted download
  after meaningless error :(
  • Loading branch information
bweir committed Feb 8, 2016
1 parent 89417cd commit bcdc2da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/propellerdevice/propellerdevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ void PropellerDevice::handleError(QSerialPort::SerialPortError e)
case QSerialPort::PermissionError: // 2
case QSerialPort::NotOpenError: // 13
case QSerialPort::UnsupportedOperationError: // 10
case QSerialPort::UnknownError: // 11
device.clearError();
break;
case QSerialPort::TimeoutError: // 12
Expand All @@ -74,7 +75,6 @@ void PropellerDevice::handleError(QSerialPort::SerialPortError e)
case QSerialPort::BreakConditionError: // 6
case QSerialPort::WriteError: // 7
case QSerialPort::ReadError: // 8
case QSerialPort::UnknownError: // 11
case QSerialPort::ResourceError: // SUPER IMPORTANT // 9
_resource_error_count++;
if (_resource_error_count > 1)
Expand Down

0 comments on commit bcdc2da

Please sign in to comment.