Fix Alpine bug with missing "theme" property, and lazy-load CSS/JS assets #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues raised in #3.
1.
theme
is undefined$panel->darkMode(true, true)
,theme
was undefined. This caused Alpine to throw console errors.theme
property from Filament's localStorage key, falling back to the panel's default theme mode.2.
SyntaxEntry
components in a modal seemed to have no effectSyntaxEntry
I noticed thehljs.highlightElement(el)
method wasn't being called, so the new elements were remaining unaffected.x-load-js
andx-load-css
, which I assume (?) was added with the intention of lazy-loading the assets.loadedOnRequest()
.Quick addendum re custom themes:
This package seems tightly coupled to the Filament base theme. Some styles were being overloaded when used with the Filament Minimal Theme. I was able to work around this by publishing the vendor views and commenting out
x-load-css
, but ideally this could be fixed in a future update.