Allow arguments to --cmd to contain tabs or multiple spaces #185
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of allowing split to separate the --cmd argument on any white space instead of specifically one space?
After a few days of fighting with the following command line syntax:
butterfly.server.py --host=0.0.0.0 --port=57575 --cmd='/usr/bin/docker run --rm -it --mount type=bind,source=/home/mark/app,target=/app,readonly myimage /bin/bash'
I was able to determine that it was breaking because I had more than one space between "readonly" and "myimage". This syntax works just fine:
butterfly.server.py --host=0.0.0.0 --port=57575 --cmd='/usr/bin/docker run --rm -it --mount type=bind,source=/home/mark/app,target=/app,readonly myimage /bin/bash'
Such a subtle difference is easily unnoticed by the user.