Preserve environment variables from the parent environment #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to set runtime configuration with environment variables in Docker. Butterfly by default discards any environment variables set by the parent environment.
This PR copies
env = os.environ
and keeps them by passing--preserve-environment
to/bin/su
.I did not test any other configurations than the one provided by
--unsecure
. This PR will probably break other configurations as-is. I am running Butterfly as a non-root user in Docker, without the ability to change the user. Access control is provided by a Nginx reverse proxy in the front.