chore: use readonly providers in StorageWriter #9822
Conversation
Rjected
requested review from
rakita,
joshieDo,
shekhirin,
rkrasiuk,
mattsse and
fgimenez
as code owners
| impl<'a, 'b, TX> StorageWriter<'a, 'b, TX> | ||
| where | ||
| TX: DbTx, | ||
| { |
There was a problem hiding this comment.
I like how you implement these methods only for ro tx, that enforces future development to uphold this performant pattern in terms of not locking db for write when not necessary
| impl<'a, 'b, TX> StateWriter for StorageWriter<'a, 'b, TX> | ||
| where | ||
| TX: DbTxMut + DbTx, | ||
| { |
There was a problem hiding this comment.
unnecessary to combine writing receipts to static files and to db in one transaction, defeats the purpose a bit of having the separation between rw and ro tx in the first place for StorageWriter. would be better if this was separated into two functions called sequentially wherever write_to_stroage is called now. a little minus for dev ex but big plus for perf.
There was a problem hiding this comment.
I don't know if it's possible to split it up that way, or what the right API would be, because whether or not static files are written to depends on the prune config (ie in append_receipts_from_blocks). Open to ideas though
This changes
StorageWriterto be generic over the transaction, allowing methods which only require a read transaction to use a read-only database provider.