Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trie): multiproof #9804

Merged
merged 7 commits into from
Jul 25, 2024
Merged

feat(trie): multiproof #9804

merged 7 commits into from
Jul 25, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Refactors the interface of reth_trie::Proof to enable multiproof generation. Will allow to get rid of duplicate logic in #9803

@rkrasiuk rkrasiuk added the A-trie Related to Merkle Patricia Trie implementation label Jul 25, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming nit, didn't look closely at the impl but nothing caught my eye

@@ -21,6 +21,9 @@ pub enum ProviderError {
/// Database error.
#[error(transparent)]
Database(#[from] crate::db::DatabaseError),
/// RLP error.
#[error(transparent)]
RLP(#[from] alloy_rlp::Error),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RLP(#[from] alloy_rlp::Error),
Rlp(#[from] alloy_rlp::Error),

@rkrasiuk rkrasiuk enabled auto-merge July 25, 2024 15:24
@rkrasiuk rkrasiuk added the C-enhancement New feature or request label Jul 25, 2024
@rkrasiuk rkrasiuk added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit c1b5410 Jul 25, 2024
33 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/trie-multiproof branch July 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants