feat(trie): more logs for proofs #13843
Merged
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
changed the title
DaniPopes
approved these changes
Jan 17, 2025
mattsse
reviewed
Jan 18, 2025
| @@ -135,6 +145,8 @@ where | |||
| H: HashedCursorFactory + Clone + Send + Sync, | |||
| { | |||
| fn blinded_node(&mut self, path: &Nibbles) -> Result<Option<RevealedNode>, SparseTrieError> { | |||
| let start = Instant::now(); | |||
There was a problem hiding this comment.
we call this a bunch because this is called in a loop.
imo this clock overhead is too expensive to perform on this level
There was a problem hiding this comment.
it's called in a loop but only for those nodes that are blinded, and we usually don't have a lot of them that need to be revealed. Nevertheless, added a check for the TRACE level for target to be enabled, so that we don't do Instant::now when not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.