Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(trie): set trie mask bits directly #13724

Merged
merged 2 commits into from
Jan 8, 2025
Merged

perf(trie): set trie mask bits directly #13724

merged 2 commits into from
Jan 8, 2025

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Jan 8, 2025 •
edited
Loading

Description

Closes #12877

Set trie mask bits directly instead of collecting them into a vec and setting later on.

@rkrasiuk rkrasiuk added C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Jan 8, 2025
@rkrasiuk rkrasiuk mentioned this pull request Jan 8, 2025
Closed
@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit bd49471 Jan 8, 2025
43 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/sparse-set-trie-mask-bits branch January 8, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set trie mask bits directly in the sparse trie
2 participants
@rkrasiuk @shekhirin