Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): Cut down on reth-primitives::TransactionSigned usage #13659

Merged
merged 3 commits into from
Jan 6, 2025
Merged

chore(consensus): Cut down on reth-primitives::TransactionSigned usage #13659

merged 3 commits into from
Jan 6, 2025
+13 −1

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Jan 5, 2025 •
edited
Loading

towards #13631

@hoank101 hoank101 mentioned this pull request Jan 5, 2025
Closed
1 task
@hoank101
Copy link
Contributor Author

hoank101 commented Jan 5, 2025

hi @mattsse please help me review, if ok, i will make another PR to update other module

@hoank101 hoank101 changed the title feat(consensus): Cut down on reth-primitives::TransactionSigned usage chore(consensus): Cut down on reth-primitives::TransactionSigned usage Jan 5, 2025
mattsse
mattsse approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jan 6, 2025
@mattsse mattsse added the A-sdk Related to reth's use as a library label Jan 6, 2025
Merged via the queue into paradigmxyz:main with commit 923a805 Jan 6, 2025
44 checks passed
@hoank101 hoank101 deleted the hoa/13631-1 branch January 18, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoank101 @mattsse