Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code label_pr.js #13526

Closed
wants to merge 1 commit into from
Closed

Conversation

teenager-ETH
Copy link

Pull Request: Fix Code label_pr.js

Title

fix code label_pr.js


Description

Add your description here...

Be sure to include:

  • A summary of the changes made.
  • The reason for the changes.
  • Any relevant details for reviewers.

Checklist

Please ensure the following before submitting the pull request:


Commit Details

Commits on Dec 23, 2024

  • fix code label_pr.js
    Author: @teenager-ETH
    Summary: Showing 5 changes: 3 additions and 2 deletions in the file .github/assets/label_pr.js.

Code Changes

File: .github/assets/label_pr.js

Modifications:

// Original code
const urlPattern = new RegExp(`(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved) ${repoUrl}/issues/(?<issue_number>\\d+)`, 'i');
const issuePattern = new RegExp(`(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved) \#(?<issue_number>\\d+)`, 'i');

// Updated code
const urlPattern = /(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved) https:\/\/repoUrl\/issues\/(?<issue_number>\d+)/i;
const issuePattern = /(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved) \#(?<issue_number>\d+)/i;

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's an url where the previous pattern is insufficient?

@teenager-ETH
Copy link
Author

What do you mean?

@mattsse
Copy link
Collaborator

mattsse commented Dec 23, 2024

unclear what this fixes, do you have an example URL that demonstrates the fix?

@mattsse
Copy link
Collaborator

mattsse commented Dec 24, 2024

closing this because the existing regex looks fine to me

@mattsse mattsse closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants