refactor(debug): simplify trie updates comparison logic #13516
Closed
+14
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bendanzhentan
commented
Dec 23, 2024
bendanzhentan
commented
- Removing redundant match patterns and nested code blocks
- Improving warning messages to show the number of mismatched entries
- Removing redundant match patterns and nested code blocks - Improving warning messages to show the number of mismatched entries
bendanzhentan
force-pushed
the
perf-in-memory-merkle-check-mismatches
branch
from
4a6ed07 to
32f9e79
Compare
|
@rkrasiuk ping |
rkrasiuk
requested changes
Jan 2, 2025
| let in_mem_updates_iter = in_memory_updates.account_nodes_ref().iter(); | ||
| let incremental_updates_iter = incremental_trie_updates.account_nodes_ref().iter(); | ||
|
|
||
| for (in_mem, incr) in in_mem_updates_iter.zip(incremental_updates_iter) { |
There was a problem hiding this comment.
if length of updates is not the same, some updates will be lost whereas previously we at least produced a warning if any items are left after iteration
There was a problem hiding this comment.
Thanks @rkrasiuk and sorry for the late reply.
You are correct. This change will emit some updates when the length is not the same.
I will close this PR.
| } | ||
| } | ||
|
|
||
| if !in_mem_mismatched.is_empty() { |
There was a problem hiding this comment.
this is incorrect because you are checking the lengths of mismatched entries whereas previously we checked whether any updates have more items
Comment on lines
+219
to
+221
| } else if !incremental_mismatched.is_empty() { | ||
| warn!(target: "reth::cli", "Incremental trie updates have {} more entries", incremental_mismatched.len()); | ||
| } |
There was a problem hiding this comment.
this path is unreachable, because if in_mem_mismatched is empty, incremental_mismatched will be empty as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.