Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop aware sender new type (fixes #13242) #13495

Merged
merged 8 commits into from
Dec 24, 2024
Merged

Add drop aware sender new type (fixes #13242) #13495

merged 8 commits into from
Dec 24, 2024
+57 −11

Conversation

ABD-AZE
Copy link
Contributor

@ABD-AZE ABD-AZE commented Dec 22, 2024

Fixes #13242

mattsse
mattsse requested changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this is great.

only have a smol nit

crates/rpc/rpc-eth-types/src/cache/mod.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-types/src/cache/mod.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the A-rpc Related to the RPC implementation label Dec 23, 2024
@ABD-AZE ABD-AZE requested a review from mattsse December 23, 2024 07:46
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13495 will not alter performance

Comparing ABD-AZE:drop-aware-sender-fixes#13242 (6dd1a73) with main (934fd1f)

Summary

✅ 77 untouched benchmarks

@ABD-AZE
Copy link
Contributor Author

ABD-AZE commented Dec 23, 2024

@mattsse should I label the fn new as const as directed by lint?

@mattsse
Copy link
Collaborator

mattsse commented Dec 23, 2024

yep,
and cargo +nightly fmt

@ABD-AZE ABD-AZE requested a review from mattsse December 23, 2024 08:26
@ABD-AZE
Copy link
Contributor Author

ABD-AZE commented Dec 24, 2024 •
edited
Loading

@mattsse can you please approve the workflow for this PR.

@mattsse mattsse force-pushed the drop-aware-sender-fixes#13242 branch 2 times, most recently from d74f335 to d3e56dd Compare December 24, 2024 09:49
@mattsse mattsse force-pushed the drop-aware-sender-fixes#13242 branch from d3e56dd to 6dd1a73 Compare December 24, 2024 09:50
@mattsse mattsse added this pull request to the merge queue Dec 24, 2024
Merged via the queue into paradigmxyz:main with commit f67625f Dec 24, 2024
43 checks passed
@ABD-AZE ABD-AZE deleted the drop-aware-sender-fixes#13242 branch December 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dropaware Sender new type
2 participants
@ABD-AZE @mattsse