perf(trie): parallel rlp node updates in sparse trie #13251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-perf
shekhirin
force-pushed
the
alexey/sparse-trie-parallel
branch
from
75d8c87 to
a50b561
Compare
shekhirin
requested review from
rkrasiuk,
Rjected and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
RevealedSparseTrie::rlp_nodetake a non-mutable reference toselfand return the list of updates that are need to be applied to the trie nodes. This allows us to run multiplerlp_nodein parallel in theRevealedSparseTrie::update_rlp_node_level, because we gather the nodes at the provided level and calculate their hashes independently from each other.