feat(op): storage root isthmus #13214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-consensus
emhane
requested review from
rakita,
onbjerg,
mattsse,
Rjected,
fgimenez,
rkrasiuk and
gakonst
as code owners
emhane
commented
Dec 7, 2024
mattsse
requested changes
Dec 11, 2024
Comment on lines
+115
to
+116
| if self.chain_spec.is_isthmus_active_at_timestamp(block.timestamp) { | ||
| let storage_root_msg_passer = self |
There was a problem hiding this comment.
this is problematic in this function,
because we use this when we validate a downloaded block, and accessing the latest state on disk might not exists.
need to figure out how to make this work.
could we in this pr introduce the isthmus check as a standalone function only and figure out where we actually need to check this separately?
Comment on lines
+988
to
+992
| impl<N: NodeTypesWithDB> fmt::Debug for BlockchainProvider<N> { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| f.debug_struct("BlockchainProvider").finish_non_exhaustive() | ||
| } | ||
| } |
There was a problem hiding this comment.
maybe submit as separate pr?
This was referenced Dec 11, 2024
|
closing, storage root verification needs to happen in execution to be possible in batch execution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13144, ref ethereum-optimism/optimism#12044