Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Add adapter type for NodePrimitives::Receipt #12674

Merged
merged 2 commits into from
Nov 19, 2024
Merged

chore(sdk): Add adapter type for NodePrimitives::Receipt #12674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f1ad07
Add adapter type for NodePrimitives::Receipt
emhane Nov 19, 2024
8078e8e
Rename Rcpt to ReceiptTy
emhane Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/primitives-traits/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ pub use size::InMemorySize;

/// Node traits
pub mod node;
pub use node::{FullNodePrimitives, NodePrimitives};
pub use node::{FullNodePrimitives, NodePrimitives, Rcpt};

/// Helper trait that requires arbitrary implementation if the feature is enabled.
#[cfg(any(feature = "test-utils", feature = "arbitrary"))]
Expand Down
3 changes: 3 additions & 0 deletions crates/primitives-traits/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,6 @@ where
type TxType = T::TxType;
type Receipt = T::Receipt;
}

/// Helper adapter type for accessing [`NodePrimitives`] receipt type.
pub type Rcpt<N> = <N as NodePrimitives>::Receipt;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan of abbreviations for aliases.

we will likely need a few more, so I think we should come up with a common prefix for these, perhaps just NodeReceipt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we rename it when we don't use reth_primitives::Receipt in the code base anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no the trait is the problem nvm...wanted smthg short...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReceiptTy? common suffix?

Loading