Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(trie): cache prefix set lookups in sparse trie #12088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(trie): cache prefix set lookups in sparse trie #12088

wants to merge 1 commit into from
+12 −7

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Oct 25, 2024 •
edited
Loading

We can save on a PrefixSet::contains lookup for those nodes that were already checked. It can happen when checking the children of a branch node and then checking the branch node again, and when checking the extension node and then checking it again.

@shekhirin shekhirin added C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Oct 25, 2024
@shekhirin shekhirin marked this pull request as ready for review October 26, 2024 11:24
@shekhirin shekhirin mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shekhirin