Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fail on unwind during reth import #12062

Merged
merged 4 commits into from
Oct 25, 2024
Merged

fix: fail on unwind during reth import #12062

merged 4 commits into from
Oct 25, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Oct 25, 2024

Should help with failing hive tests.

Added fail_on_unwind flag to Pipeline. If set, any unwind results in error in Pipeline::run. It is only set in build_import_pipeline

@Rjected Rjected changed the title fix: fail on unwing during reth import fix: fail on unwind during reth import Oct 25, 2024
mattsse
mattsse approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @onbjerg

@mattsse mattsse added the A-staged-sync Related to staged sync (pipelines and stages) label Oct 25, 2024
onbjerg
onbjerg reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to run this in hive first and see if it resolves some of the issues

@onbjerg onbjerg added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 58441c1 Oct 25, 2024
40 checks passed
@onbjerg onbjerg deleted the klkvr/fail-on-unwind branch October 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klkvr @onbjerg @mattsse