Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Start to implement flashbots_validateBuilderSubmissionV3 #12061

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

ryanschneider
Copy link
Contributor

@ryanschneider ryanschneider commented Oct 24, 2024

This first incremental version just accepts all inputs it can deserialize for flashbots_validateBuilderSubmissionV3. To make it clear this is the case, it logs each request at warning level.

The older V1 and V2 RPCs are left unimplemented, they were used for older forks so I can't see a good reason to implement them, but they are needed to complete the BlockSubmissionValidationApiServer trait.

Next steps are:

But just having this stub available allows us to make progress on switching https://github.com/ethpandaops/ethereum-package/tree/bbusa/rbuilder over to using rbuilder and reth for block building in kurtosis.

* Currently just parses params and accepts all inputs.
* Mainly so we can unblock kurtosis testing for pectra
@mattsse mattsse added the A-rpc Related to the RPC implementation label Oct 25, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baby steps

@mattsse mattsse added this pull request to the merge queue Oct 26, 2024
Merged via the queue into paradigmxyz:main with commit f616de6 Oct 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants